meta-lxatac-bsp: barebox: increase boot timeout when serial booting #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hnez
force-pushed
the
barebox-serial-timeout
branch
from
d895e9f
to
685cfe1
Compare
jluebbe
reviewed
Apr 4, 2024
meta-lxatac-bsp/recipes-bsp/barebox/files/lxatac/env/init/20_serial_timeout.sh
Outdated
Show resolved
Hide resolved
hnez
force-pushed
the
barebox-serial-timeout
branch
from
29c2e7d
to
d9f330a
Compare
|
This PR got kind of forgotten some time ago. I think the change is good, so we should get this merged. |
Bareboxes hush shell behaves mostly like a normal shell scripting language, but differs a bit here and there. Instead of ignoring these differences on a file-by-file basis we can instead add one central .shellcheckrc file. Signed-off-by: Leonard Göhrs <[email protected]>
When someone loads barebox via serial download instead of e.g. from the eMMC it is very likely that they want to upload an image via fastboot next and do not want to autoboot into linux right away. Give them a bit more time to interrupt the boot process. Signed-off-by: Leonard Göhrs <[email protected]>
hnez
force-pushed
the
barebox-serial-timeout
branch
from
d9f330a
to
2ffd579
Compare
jluebbe
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone loads barebox via serial download instead of e.g. from the eMMC it is very likely that they want to upload an image via fastboot next and do not want to autoboot into linux right away.
Give them a bit more time to interrupt the boot process.
This PR is based on a discussion in PR #125 (comment).
There @a3f also brings up other points that concern the flashing guide in the README:
TODO before merging:
[ ] Inverstigate what @a3f said about the effect ofwd -xand change the README accordingly.The investigation is a separate topic from the change introduced here.